-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to check formatting for the text under the caret. #10973
Conversation
See test results for failed build of commit fbe51228f9 |
I personally agree with the change here. But: |
Thanks for the heads up here - yes I agree with the change and the reasoning. It will necessitate an update to Basic Training, as you mention @michaelDCurran the module does note that the command reports formatting at the review cursor rather than text caret. I'm happy to update the module before this change makes it to a stable release. I'll also need to check the NVDA Certified Expert Exam questions as it is in there too. |
This will probably need to be adjusted accordingly also in the user guide. I can have alook and do it unless @lukaszgo1 has time to do it. |
@Adriani90 I've updated User guide as part of this PR. Could you please take a look and tell me if it's sufficient in your opinion? |
@lukaszgo1 it looks good. One question though, the command for reporting text formatting under the braille cell, which formatting is there applied? On review, on carret, or does it deppend on to which cursor the braille display is tethered? |
@Adriani90 wrote:
It depends on the location of braille cursor.
I don't think so. You can check formatting at the position of the braille cursor with the current gesture from a braille display, and if someone wants to check formatting for the different cursor one of the gestures added in this PR could be assigned to a key combination on a braille display from the input gestures dialog already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only commenting on the user guide text, which looks fine, well done.
…g info at caret to report in MS Excel (#11914) * Fallback to POSITION_FIRST when reporting formatting info at caret to report in Excel cells * Update what's new Co-authored-by: Michael Curran <[email protected]>
Several commits were missed when branching for Release 2020.4 (see PR #11910) which selected commit f99644e, however there are 3 commits after that and 325be94 (inclusive) before the version number was updated. Merge to the 2020.4 beta: - Fix: NVDA no longer fails to restart when running from sources and cw… 3737e3c - MS Word: report the number of pts of line spacing when line spacing t… 9c0b649 - Fix-up of #10973: Fallback to POSITION_FIRST when reporting formattin… 325be94
Link to issue number:
Closes #9505
First step towards #7314
Summary of the issue:
It is not possible to check formatting for the text under the caret without moving review cursor to its position. This is problematic for people working with review cursor not following caret. In addition this can be done with a braille display, so it should also be possible for speech only users.
Description of how this pull request fixes the issue:
I've created a separate script assigned to NVDA+f to check formatting at the caret position. The current command for checking it at the review cursor has been reassigned to NVDA+shift+f because for most users checking formatting happens more often at the caret not at the review cursor. As by default review follows caret there is no functional difference for people who haven't changed this.
While at it I've also split up these scripts into a separate ones as per #7314 - they are obviously not assigned.
Testing performed:
Known issues with pull request:
Change log entry:
New features:
It is now possible to check formatting at the caret with NVDA+f
Changes:
Command used to check formatting at review position has been reassigned to NVDA+shift+f