-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nvda find title cancellation #11632
Merged
Merged
Commits on Sep 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0c01090 - Browse repository at this point
Copy the full SHA 0c01090View commit details -
Many NVDAObjects derive from Window, including IAccessible. This meant that the fix for focus changes in Gmail was bypassed! Looking at the log, after opening NVDA Find dialog the last queued focus object is set to the following: - NVDAObjects.Dynamic_NvdaDialogDialogIAccessibleWindowNVDAObject - NVDAObjects.Dynamic_IAccessibleEditWindowNVDAObject The first is the dialog, the second the edit field. The full MRO for the dialog is: - class 'NVDAObjects.Dynamic_NvdaDialogDialogIAccessibleWindowNVDAObject' - class 'appModules.nvda.NvdaDialog' - class 'NVDAObjects.behaviors.Dialog' - class 'NVDAObjects.IAccessible.IAccessible' - class 'NVDAObjects.window.Window' - class 'NVDAObjects.NVDAObject' - class 'documentBase.TextContainerObject' - class 'baseObject.ScriptableObject' - class 'baseObject.AutoPropertyObject' - class 'garbageHandler.TrackedObject' - class 'object' Excluding speech cancellation on 'NVDAObjects.behaviors.Dialog' seems to generally make sense, resolves the NVDA Find dialog speech for focus cancellation, and does not appear to interfere with the Gmail fix.
Configuration menu - View commit details
-
Copy full SHA for 224dee1 - Browse repository at this point
Copy the full SHA 224dee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3b26dc - Browse repository at this point
Copy the full SHA d3b26dcView commit details
Commits on Sep 24, 2020
-
WIP use api.getForegroundObject
To avoid window change speech from getting cancelled
Configuration menu - View commit details
-
Copy full SHA for ace2e4a - Browse repository at this point
Copy the full SHA ace2e4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2dcb6c - Browse repository at this point
Copy the full SHA d2dcb6cView commit details
Commits on Oct 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b48eaa8 - Browse repository at this point
Copy the full SHA b48eaa8View commit details -
Readability of focus lost cancelled speech
Encapsulate logic in a class, clarify ownership of obj ref.
Configuration menu - View commit details
-
Copy full SHA for aada2f1 - Browse repository at this point
Copy the full SHA aada2f1View commit details
Commits on Oct 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for efe98ce - Browse repository at this point
Copy the full SHA efe98ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf697a7 - Browse repository at this point
Copy the full SHA bf697a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8782e40 - Browse repository at this point
Copy the full SHA 8782e40View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce46082 - Browse repository at this point
Copy the full SHA ce46082View commit details
Commits on Oct 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9db07e2 - Browse repository at this point
Copy the full SHA 9db07e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b0454 - Browse repository at this point
Copy the full SHA f7b0454View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.