Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nvda find title cancellation #11632

Merged
merged 13 commits into from
Oct 8, 2020
Merged

Commits on Sep 18, 2020

  1. Configuration menu
    Copy the full SHA
    0c01090 View commit details
    Browse the repository at this point in the history
  2. Use dialog instead of Window

    Many NVDAObjects derive from Window, including IAccessible.
    This meant that the fix for focus changes in Gmail was bypassed!
    
    Looking at the log, after opening NVDA Find dialog the last
    queued focus object is set to the following:
    - NVDAObjects.Dynamic_NvdaDialogDialogIAccessibleWindowNVDAObject
    - NVDAObjects.Dynamic_IAccessibleEditWindowNVDAObject
    
    The first is the dialog, the second the edit field.
    
    The full MRO for the dialog is:
    - class 'NVDAObjects.Dynamic_NvdaDialogDialogIAccessibleWindowNVDAObject'
    - class 'appModules.nvda.NvdaDialog'
    - class 'NVDAObjects.behaviors.Dialog'
    - class 'NVDAObjects.IAccessible.IAccessible'
    - class 'NVDAObjects.window.Window'
    - class 'NVDAObjects.NVDAObject'
    - class 'documentBase.TextContainerObject'
    - class 'baseObject.ScriptableObject'
    - class 'baseObject.AutoPropertyObject'
    - class 'garbageHandler.TrackedObject'
    - class 'object'
    
    Excluding speech cancellation on 'NVDAObjects.behaviors.Dialog' seems to
    generally make sense, resolves the NVDA Find dialog speech for focus
    cancellation, and does not appear to interfere with the Gmail fix.
    feerrenrut committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    224dee1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3b26dc View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. WIP use api.getForegroundObject

    To avoid window change speech from getting cancelled
    feerrenrut committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    ace2e4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2dcb6c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Configuration menu
    Copy the full SHA
    b48eaa8 View commit details
    Browse the repository at this point in the history
  2. Readability of focus lost cancelled speech

    Encapsulate logic in a class, clarify ownership of obj ref.
    feerrenrut committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    aada2f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. remove temp debug logging

    feerrenrut committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    efe98ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf697a7 View commit details
    Browse the repository at this point in the history
  3. Fix indentation level

    feerrenrut committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    8782e40 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ce46082 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    9db07e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7b0454 View commit details
    Browse the repository at this point in the history