-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add styles for userguide and changes #12027
Conversation
Note: I haven't updated the appveyor file to package the css with the docs. For reviewing a build I don't think this is necessary. @michaelDCurran could you comment on what we would need to do to get the css file to accompanying the userguide / changes file to the website? @Qchristensen, here is a demo: |
… userGuide or changes files.
Although styles.css was being copied to each language directory, it also needs to be copied to the output directory. Thus I just pushed a commit that ensures that styles.css is copied to the output directory if the userGuide or changes targets are requested to be build with scons. |
I'm not sure I follow, can we merge this and just delay updating the appveyorHook until after 2020.4 is released? |
You're right, there is no disadvantage to merging this to master at any
time. I thought the snapshots page linked to a changes.html file, but
these days it just links to a github git commit log, so that is fine.
But once this does ever hit the beta branch, the appVeyorHook must be
updated before any beta, rc or final release is made.
|
Ok, in that case I'll wait for @Qchristensen to review / approve the style choices and we can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I agree, no urgency with merging it.
I didn't comment on the style, but I like the use of the purple. My only thoughts were
I thought maybe changes like that which weren't critical could be done later down the track. |
Thanks for taking a look @Qchristensen, yes those changes could be made fairly easily after this is merged. The other thing I was hoping we could do was to delineate shortcuts clearly. I'll merge this in now. It should be visible when docs are launched from NVDA, but won't become available on our website until 2021.1 reaches beta. |
Link to issue number:
None
Summary of the issue:
The user guide has long since been missing any basic styling. While very utilitarian, the default appearance will likely be perceived by many as ugly and potentially hard to read.
Description of how this pull request fixes the issue:
Add simple style rules for the user guide, changes file, and key commands
Testing performed:
Tested opening these from NVDA.
Known issues with pull request:
None
Change log entry:
Section: Changes