Build NVDA with Python 3.8 32-bit #12042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of Python 3.7 is 3.7.9 (as of February 2021). Therefore remove 3.7.6 check.
|
See test results for failed build of commit 6301195cec |
lukaszgo1
reviewed
Feb 6, 2021
scons.bat
Outdated
| @@ -6,7 +6,7 @@ where py 1>nul 2>&1 | |||
| if "%ERRORLEVEL%" == "0" ( | |||
| rem Python launcher is present in the PATH | |||
| rem Call python 3.7 for 32 bits | |||
There was a problem hiding this comment.
Please upgrade this comment to mention Python 3.8
|
Hi, it is already targeting py3.8 branch, and I can take care of other comments today. Thanks.
From: Łukasz Golonka <[email protected]>
Sent: Saturday, February 6, 2021 7:23 AM
To: nvaccess/nvda <[email protected]>
Cc: Joseph Lee <[email protected]>; Author <[email protected]>
Subject: Re: [nvaccess/nvda] SConstruct: build NVDA with Python 3.8 32-bit (#12042)
The copyright header upgrade would conflict with the work from #11967 <#11967> and since #11967 <#11967> is almost certainly going to be merged before this PR it makes sense to revert it. Have you considered re-targeting this to the py3.8 branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#12042 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEBX6P6KET2RX6VSC4LS5VNGDANCNFSM4XFIWFSQ> .
|
|
Please double check - for me GitHub shows Master as a target branch. |
|
Corrected.
|
This reverts commit 096f61b due to impending Py2Exe upgrade that will update copyright header.
michaelDCurran
changed the title
|
I have taken the opportunity to change readme.md and appveyor.yml in this pr to mention/use Python 3.8, as it makes sense to change sconstruct, readme and appveyor all at once when we merge this to the py3.8 branch. However, we do not expect the py3.8 branch to actualy run with appveyor yet though as there are several large dependencies that much also change, which will be done in separate prs. |
michaelDCurran
approved these changes
Feb 15, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Required to build NVDA under Python 3.8:
Link to issue number:
None
Summary of the issue:
Currently SConstruct runs Python 3.7 to build NVDA.
Description of how this pull request fixes the issue:
Directs SConstruct to build NVDA under Python 3.8 32-bit.
Testing strategy:
Known issues with pull request:
None
Change log entry:
None
Code Review Checklist:
As this is an internal change, only applicable tests are shown:
Note: system tests is excluded as it is not really required to build the PR build until AppVeyor is ready to run Python 3.8 to build NvDA.
Thanks.