TextInfos must inherit from BaseContentRecogTextInfo

[seanbudd]

Link to issue number:

Part of #12123

Implements deprecation announced in: #11510

Summary of the issue:

TextInfos that are used in content recognition module contentRecog must inherit from BaseContentRecogTextInfo

Description of how this pull request fixes the issue:

Code was which manually added BaseContentRecogTextInfo API functions updateCaret, updateSelection to TextInfos is removed.

Unused helper functions for the removed code was also removed

Instances where RuntimeErrors were passed into RecogResultNVDAObject were replaced with raising the errors directly.

Testing strategy:

• in RecogResultNVDAObject.makeTextInfo ti can be assigned from 3 locations, but only two ways: self.result.makeTextInfo  and self._selection.copy()
• self._selection is set from the __init__, ( self._selection = self.makeTextInfo(textInfos.POSITION_FIRST) ) and will be the result of ti = self.result.makeTextInfo  . So we only have to look at where result comes from.
• result is passed in when the class is created, looking for usages of RecogResultNVDAObject , it is only from def _recogOnResult but result is passed into that as well.
• If you look for where that is called you'll find def recognize in uwpOcr.py
• Here, the result LinesWordsResult(data, imgInfo) is passed eventually passed into RecogResultNVDAObject via _recogOnResult, the RuntimeErrors passed in are handled in _recogOnResult
• LinesWordsResult.makeTextInfo creates a LwrTextInfo  object, which subclasses BaseContentRecogTextInfo

Search the code base for usages of _patchTextInfo and confirm the only usages are self references and in the removed code.

find . -type f -name '*.py' -exec grep -P "\b_patchTextInfo\b" {} +

Search the code base for usages of _setSelection and confirm the only usages are in the removed code.

find . -type f -name '*.py' -exec grep -P "\b_setSelection\b" {} +

Known issues with pull request:

None

Change log entry:

Developer Changes

- Support of `TextInfo`s that do not inherit from `contentRecog.BaseContentRecogTextInfo` is removed (#12157)

Code Review Checklist:

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual tests.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.

[feerrenrut]

Thanks @seanbudd