don't rely on star imports from synthDriverHandler #12172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Currently a few modules relies on star imports from
synthDriverHandler
making it unnecessarily difficult to perform refactoring (I've stumbled on this when writing code for #12168)Description of how this pull request fixes the issue:
Now both
settingsDialogs
andglobalCommands
are importing what they need explicitly.Testing strategy:
synthDriverHander
from synthDriver import *
I've executed flake8 for the entire file and imported explicitly only whatever they were using.Known issues with pull request:
None known
Change log entry:
Code Review Checklist: