Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Outlook attachment list to read again #12274

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Allow Outlook attachment list to read again #12274

merged 1 commit into from
Apr 7, 2021

Conversation

michaelDCurran
Copy link
Member

Link to issue number:

Fixes #12265

Summary of the issue:

After merging of pr #12210 , The attachment list in Outlook no longer read with NVDA, and an error was produced in the log.
It seems that Outlook's attachment list, gives back a NULL pointer for the SelectionContainer property on its UIA SelectionItemPattern.

Description of how this pull request fixes the issue:

Check to see if CurrentSelectionContainer is NULL and return None as there is nothing further we can do with that pattern.

Testing strategy:

Known issues with pull request:

None.

Change log entry:

None needed.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

…selectionContainer on UIA's SelectionItemPattern, such as for Lutlook Attachment lists.
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@michaelDCurran michaelDCurran merged commit 62eaba5 into master Apr 7, 2021
@michaelDCurran michaelDCurran deleted the i12265 branch April 7, 2021 06:48
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvda does not read the list of attachments in outlook
4 participants