Elements List: Don't remove the label of a filled spin button input field (#12317) #12318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12317
Fix-up of PR #6131
Summary of the issue:
In browse mode documents, when a spin button input field is filled with a value, its label goes missing from the Elements List dialog.
Description of how this pull request fixes the issue:
Remove the role ROLE_SPINBUTTON from the set of exceptions for which the content replaces the label.
Testing strategy:
In Firefox / Chrome / Edge Chromium:
Ensure the label is present with empty spin button input field.
Ensure the label is present with non-empty spin button input field.
Known issues with pull request:
There might be other roles for which both the label and content are desirable.
For the record, remaining exceptions as of this PR are:
Change log entries:
I do not think this small fix deserves a change log entry.
Code Review Checklist: