Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up from #12210: Excel without UIA enabled: again allow typing and editing in cells #12321

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Apr 22, 2021

Link to issue number:

Fixes #12303

Summary of the issue:

After merging of pr #12210 editing cells in Excel without UIA enabled became im possible as NVDA did not report / track focus had ented the Cell Edit control.
This was due to the EXCEL6 window accidentally being marked as having a good UIA implementation. This was testing code left over from the early implementation of #12210.

Description of how this pull request fixes the issue:

Remove EXCEL6 from the good UIA windows list.
Also ensure that MSAA focus events on this window are ignored when using Excel with UIA enabled, as Excel will fire its own UIA focus event on an edit control within the active cell.

Testing strategy:

Testing with all combinations of NvDA's use Microsoft Excel with UI Automation setting, and Excel's allow directly editing in a cell setting (4 different variations possible):
In an Excel spreadsheet:

  • Started typing into a cell. Ensured that NVDA was announcing the typed characterrs, and that it announced focus moving into the edit control.
  • Pressed f2 on a cell, ensured that NVDA announced focus on the edit control, that characters were announced when typed, and that moving the cursor with left and right arrows would speak the characters in the edit control.

This was successful for all 4 variations of the two settings.

Known issues with pull request:

None known.

Change log entries:

None needed.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

…nore MSAA focus events on EXCEL6 (old formula edit) window, as they are not needed as Excel will fire a more useful UI Automation focus event on an edit control within the active cell.
@michaelDCurran michaelDCurran requested a review from a team as a code owner April 22, 2021 03:16
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the suggested method in the PR, and confirmed that the original issue is fixed. LGTM

@michaelDCurran michaelDCurran merged commit 03746a1 into master Apr 22, 2021
@michaelDCurran michaelDCurran deleted the i12303 branch April 22, 2021 03:58
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants