-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher: Honor the --minimal command line parameter (#12289) #12322
Launcher: Honor the --minimal command line parameter (#12289) #12322
Conversation
Avoid playing nvda_logo.wav when started with --minimal
429980c
to
580c6d2
Compare
@feerrenrut, |
I'd prefer that a restyle was done in a separate PR. If you are willing to do the testing, I'll happily take it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, thanks for doing that. I've just tested this locally and can confirm that the startup sound is not played.
However, NVDA still speaks through the process. I think the main use case for this argument is for mass unattended installations. Would you be willing to extend this to also tell the temporary copy to be set to no-speech?
Currently |
@lukaszgo1 wrote:
I agree. @feerrenrut wrote:
I'll prepare the two PRs ( |
Currently the userguide has the following explanations:
I'm sure you are both aware of this already, but for completeness. From https://techterms.com/definition/silent_install
Since our docs are not very specific, and most people will expect "install-silent" to produce no UI at all, graphical, speech, or otherwise. I'd make that the option that controls this. On the other hand the docs for The main use cases I am aware of are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JulienCochuyt
Link to issue number:
Fixes #12289
Summary of the issue:
The
nvda_logo.wav
sound is played even if the launcher is started with the--minimal
command line parameter.Description of how this pull request fixes the issue:
Avoid playing the
nvda_logo.wav
sound if the launcher is started with the--minimal
command line parameter.Testing strategy:
Started with different combinations of command line parameters.
Ensure they are still interpreted as expected.
Known issues with pull request:
Change log entries:
Bug fixes
The NVDA installer now also honors the
--minimal
command line parameter and does not play the start-up sound, following the same documented behavior as an installed or portable copy NVDA executable.Code Review Checklist: