Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor the exit of nvda and gui.terminate" #12326

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

seanbudd
Copy link
Member

Reverts #12286

@seanbudd seanbudd requested a review from a team as a code owner April 22, 2021 23:52
@AppVeyorBot
Copy link

See test results for failed build of commit 57dc902eba

@michaelDCurran michaelDCurran merged commit d9afe35 into master Apr 23, 2021
@michaelDCurran michaelDCurran deleted the revert-12286-cleanup-exit branch April 23, 2021 03:55
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 23, 2021
@Brian1Gaff
Copy link

Brian1Gaff commented Apr 23, 2021 via email

@seanbudd
Copy link
Member Author

You are aware that the current alpha as of yesterday is seriously broken, and will not run sensibly on anything I suppose? Brian @.*** Sent via blueyonder. Please address personal E-mail to:- @., putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Michael Curran" @.> To: "nvaccess/nvda" @.> Cc: "Subscribed" @.> Sent: Friday, April 23, 2021 4:56 AM Subject: Re: [nvaccess/nvda] Revert "refactor the exit of nvda and gui.terminate" (#12326)

Merged #12326 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #12326 (comment)

Just to confirm, you are referring to the latest alpha alpha-22498,d9afe35d, which includes this PR that has reverted the broken change?

@CyrilleB79
Copy link
Collaborator

@seanbudd, @michaelDCurran:
Since #12286 was reverted through this PR, shouldn't #12238 be reopened?

@seanbudd
Copy link
Member Author

Yes, thanks @CyrilleB79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants