Fix Sapi4 pitch change #12311

[cary-rowen]

Link to issue number:

#12311

Summary of the issue:

This pr solves the problem in #12311 , To put it simply, Starting with version 2019.3, the "Capital pitch change" when using the SAPI4 synthesizer was invalid.
But this must be incorrect behavior.
For visually impaired developers, this feature is especially important when typing and checking code.

Description of how this pull request fixes the issue,

I don't know why.
this function is marked as unavailable in the speak function, I managed to add this part of the code, and tested it, it works well.

Testing strategy:

1. Start NVDA and press NVDA + CTRL + S to select "Microsoft Speech API version 4" and confirm.
2. At this point the NVDA should have switched to the SAPI4 synthesizer and you will need to press NVDA + CTRL + V to open the Voice Setup dialog.
3. Use the Tab key to navigate until you hear "Capital pitch change percentageeditselected 30" You can change this value to 40 (or higher, or leave it unchanged).
4. Then use Windows + R to open the Run dialog and type notepad and confirm, this will open notepad allowing you to type some text.
5. Press the Caps lock key (it may be located to the left of the letter A) You may need to press it twice in a row until you hear "Caps lock on".
6. Try to enter some letters, such as the letter "C" (or "D" or something else)
7. Use Left Arrow or Right Arrow to move between these letters.

You will hear NVDA report these capital letters in a higher pitch.

Known issues with pull request:

None

Change log entries:

Bug fixes:

• Fixed the pitch change failure in Sapi4 speech synthesizer. (Starting with version 2019.3, the "Capital pitch change" when using the SAPI4 synthesizer was invalid #12311)

Code Review Checklist:

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual tests.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.

[AppVeyorBot]

• PR introduces Flake8 errors
• Build (for testing PR)

See test results for failed build of commit 49948ab928

[lukaszgo1]

This should be converted into a draft until Linter warnings are fixed.

[cary-rowen]

Hi!
How should I fix Linter warning: "E225 missing whitespace around operator"
Other codes in NVDA don't seem to add spaces before and after the operators. Sorry, I may not be familiar with github.
Thanks.
@lukaszgo1

[lukaszgo1]

How should I fix Linter warning: "E225 missing whitespace around operator"
Other codes in NVDA don't seem to add spaces before and after the operators. Sorry, I may not be familiar with github.

For the new code there are spaces on both sides of operators so you just need to add them. The code is being updated gradually to the new style that is why it may seems inconsistent.

[XLTechie]

Specifically, various operators should look like this: result = 1 + 1 def test(a, b, c=None): See the linting readme, at [tests/lint/readme.md](https://github.com/nvaccess/nvda/tree/master/tests/lint)

[cary-rowen]

I corrected all Linter warnings. Can the PR be reviewed now?
Thanks.
@lukaszgo1

[feerrenrut]

Thanks @cary-rowen

[cary-rowen]

I have improved some descriptions of the PR, and it is now clearer.

[cary-rowen]

Most of the work of this PR was done by my friend @chenfu2000 Currently, it looks good.

[LeonarddeR]

I was looking at this code and this really feels incorrect to me. It looks like the caps pitch change is applied to every pitch change, regardless of whether it is related to capital letters.

[cary-rowen]

OK, I see you've opened a PR to try and fix this, that's great.