-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sapi4 pitch change #12311 #12354
Conversation
See test results for failed build of commit 49948ab928 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be converted into a draft until Linter warnings are fixed.
Hi! |
This comment has been minimized.
This comment has been minimized.
For the new code there are spaces on both sides of operators so you just need to add them. The code is being updated gradually to the new style that is why it may seems inconsistent. |
Specifically, various operators should look like this:
result = 1 + 1
def test(a, b, c=None):
See the linting readme, at
[tests/lint/readme.md](https://github.com/nvaccess/nvda/tree/master/tests/lint)
|
This comment has been minimized.
This comment has been minimized.
I corrected all Linter warnings. Can the PR be reviewed now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cary-rowen
I have improved some descriptions of the PR, and it is now clearer. |
Most of the work of this PR was done by my friend @chenfu2000 Currently, it looks good. |
@@ -123,6 +129,16 @@ def speak(self,speechSequence): | |||
elif isinstance(item, CharacterModeCommand): | |||
textList.append("\\RmS=1\\" if item.state else "\\RmS=0\\") | |||
charMode=item.state | |||
elif isinstance(item, PitchCommand): | |||
offset = int(config.conf["speech"]['sapi4']["capPitchChange"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at this code and this really feels incorrect to me. It looks like the caps pitch change is applied to every pitch change, regardless of whether it is related to capital letters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see you've opened a PR to try and fix this, that's great.
Link to issue number:
#12311
Summary of the issue:
This pr solves the problem in #12311 , To put it simply, Starting with version 2019.3, the "Capital pitch change" when using the SAPI4 synthesizer was invalid.
But this must be incorrect behavior.
For visually impaired developers, this feature is especially important when typing and checking code.
Description of how this pull request fixes the issue,
I don't know why.
this function is marked as unavailable in the speak function, I managed to add this part of the code, and tested it, it works well.
Testing strategy:
You will hear NVDA report these capital letters in a higher pitch.
Known issues with pull request:
None
Change log entries:
Bug fixes:
Code Review Checklist: