Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements List dialog: Remove the accelerator key on the "Activate" button (#6167) #12369

Conversation

JulienCochuyt
Copy link
Collaborator

Link to issue number:

Fixes #6167

Summary of the issue:

In the English locale, there is an accelerator key collision between the "Annotation" element type and the "Activate" button, both set to the letter "A".
In the French locale, there is collision between the element type "Form field" ("Champs de formulaire") and the same button ("Activer"), both set to the letter "C".

This changes the behavior of the accelerator key that focuses the radio button but does not activate it.
This is not a bug at all, but is not ergonomically optimum, especially for less advanced users.

Description of how this pull request fixes the issue:

As suggested by @Qchristensen, remove the accelerator key setting from the "Activate" button as it is, when available, the default action of the dialog upon pressing the enter key.

In most locale, this change should not raise the need for a new translation, as the "Activate" label already exists without an accelerator marker as "a message reported when the action at the position of the review cursor or navigator object is performed.".
Just to be sure, I also added a warning in the translators comment for the button label to ask them to beware of the risk of collision.

Testing strategy:

Rendered the dialog from a source copy.
Ensured the accelerator key is removed from the button.

Known issues with pull request:

If some locale did set a more explicit message for the "a message reported when the action at the position of the review cursor or navigator object is performed." use, they might not be warned by the translation system that they need to review this label.
I guess most locales would have keep it short though, retaining the same meaning as the button.
Would separation of the two translatable strings be needed, this would be a task for pgettext, but then require every locale to be provided a new translation.

Change log entries:

Changes
In the Elements List dialog, the accelerator key on the "Activate" button has been removed in some locales to avoid collision with an element type radio button label. When available, the button is still the default of the dialog and as such can still be invoked by simply pressing enter from the elements list itself.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

…tton (nvaccess#6167)

Note to translators: Beware not to set an accelerator that would collide with other controls
in this dialog, such as an element type radio label.
@JulienCochuyt JulienCochuyt requested a review from a team as a code owner May 5, 2021 21:53
@michaelDCurran michaelDCurran merged commit e2c206d into nvaccess:master May 9, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone May 9, 2021
@JulienCochuyt JulienCochuyt deleted the i6167-elementsListActivateAccel branch May 9, 2021 23:39
michaelDCurran added a commit that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alt+a focuses but does not select "annotations" in NVDA Elements list dialog in Word
3 participants