Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting and location of changelog entries #12390

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented May 10, 2021

Link to issue number:

None

Summary of the issue:

A changes item was accidentally added to the wrong release header in PR #11598

Description of how this pull request fixes the issue:

Move the changelog item to the correct release

Testing strategy:

Note that this PR #11598 that it references is from the 2021.1 milestone and is unreleased.

Known issues with pull request:

None

Change log entries:

yes

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd requested a review from a team as a code owner May 10, 2021 06:56
@seanbudd seanbudd added this to the 2021.1 milestone May 10, 2021
@seanbudd seanbudd changed the title move changes to correct header fix formatting and location of changelog entries May 10, 2021
@seanbudd seanbudd mentioned this pull request May 10, 2021
1 task
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that was my mistake. Thanks for fixing it up @seanbudd

@feerrenrut feerrenrut removed the request for review from michaelDCurran May 10, 2021 08:49
@seanbudd seanbudd merged commit 01605b6 into master May 10, 2021
@seanbudd seanbudd deleted the move-changes-msg branch May 10, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants