-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move/remove imports to prevent circular dependencies #12404
Conversation
See test results for failed build of commit 73fdb7b609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the target to beta, and merge. We'll need to do another beta to master merge soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff includes unrelated stuff from master (Eg the CLDR changes). You'll need to rebase.
721437d
to
87ae1ea
Compare
2fb0ab2
to
e0536d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seanbudd
@feerrenrut I'm unable to merge this |
Link to issue number:
Fixes #12399
Summary of the issue:
NVDA fails to uninstall addons which import
gui
due to a circular dependency going from speech.py -> sayAll.pyWhile the refactor of speech/sayAll #12251 was designed to make fixing this problem simpler, it did not actually fix this issue.
Description of how this pull request fixes the issue:
Testing strategy:
Manual testing that #12399 is fixed
Known issues with pull request:
none
Change log entries:
None needed
Code Review Checklist: