-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable caret event detection for IA2Web #16815
Conversation
WalkthroughThe recent changes focus on improving NVDA's handling of caret movement events, particularly for browsers like Firefox and Chromium. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NVDA
participant Browser
participant IAccessible2
User->>Browser: Move caret (e.g., arrow keys)
Browser->>IAccessible2: IA2_EVENT_TEXT_CARET_MOVED event
IAccessible2->>NVDA: Send caret moved event
NVDA->>IAccessibleHandler: Process caret event
IAccessibleHandler->>NVDA: Update caret position
NVDA->>User: Provide feedback on caret position
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
CC @jcsteh
Link to issue number:
Fixes #11545
Summary of the issue:
We do not rely on caret events for IA2.
Description of user facing changes
Possibly slightly faster caret navigation in Firefox and Chrome.
Description of development approach
Testing strategy:
Verified that IA2_EVENT_TEXT_CARET_MOVED is fired for:
Known issues with pull request:
None known
Code Review Checklist:
Summary by CodeRabbit
Bug Fixes
Documentation
Refactor
caretMovementDetectionUsesEvents
attribute from theIa2Web
class to streamline code related to caret movement detection.