-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a locationHelper module for code related to locations, rectangles and points #7537
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
3ad47de
* Created a new locationHelper module
9d84968
Merge remote-tracking branch 'origin/master' into locationHelper
fb646bd
Use isinstance instead of type(self) is cls
8de022d
Review actions
b9d0bac
Merge remote-tracking branch 'origin/master' into locationHelper
b9c04c5
Class renames
1aaa5c0
Fix __radd__ operator function for Points
e3f8f3a
Added unit test for rect center
7308287
Rename rectangle operators, remove the sub operator as it does not ma…
070bb36
Rename Point operators
c2e29fd
Added many more tests, fixed operator overload (__neq__ should be __n…
2c9ef24
More unit tests for ctypes, fix __rsub__ for Points
3dbfc75
Fix for getting a center point for a rectangle, including proper roun…
81d3f98
Last edge case tests
0ba335a
Another implementation for subset and superset, doc string for collec…
e49888c
Remove wx.Rect from supported classes
c6d147f
Raise ValueError when left>right and top>bottom for RectLTRB
62c380e
Merge remote-tracking branch 'origin/master' into locationHelper
7f2cb6f
Add additional tests, improve code style for tests
c7f792d
Merge remote-tracking branch 'origin/master' into locationHelper
4487aa7
Remove locationHelper implementation from sysListView32
7e94522
Syslistview32: validate the rectangle before creating a RectLTWH inst…
3d351f2
Review actions
25896ba
Fix mistake in toRectLTRB function
dfc7e0d
Merge remote-tracking branch 'origin/master' into locationHelper
e407922
Review actions for SysListView32
3679aac
When a rectangle is created from only one point, make its width and h…
d456b2e
Merge remote-tracking branch 'origin/master' into locationHelper
80de132
Add fromNonInts factory function
4b4adf3
Use fromNonInts factory function for UIA locations, which are floats
7a05387
Refactoring
6c99d8c
Merge remote-tracking branch 'origin/master' into locationHelper
8e808ec
Merge remote-tracking branch 'origin/master' into locationHelper
5dfca2f
Add expandOrShrink helper method to rectangles, useful for focus high…
5d4ec65
Merge remote-tracking branch 'origin/master' into locationHelper
f055c9c
Review actions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering this is expecting a one-based index, I think this function should assert that
index > 0