Report the same formatting when pressing the reportFormatting script multiple times #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before fetching formatting in case this or called code happens to mutate the TextInfo.
|
Closing in favor of pr #7189 which also touches this code. |
dkager
added a commit
to dkager/nvda
that referenced
this pull request
Feb 13, 2018
michaelDCurran
pushed a commit
that referenced
this pull request
Mar 28, 2018
* Add a "report formatting info for text under this braille cell" command. * Assign the Alva BC6 secondary cursor routing keys to the new report formatting command. * Update copyrights. * Update user guide for the new Alva BC6 key assignment. * Also use the new report formatting braille command in both Papenmeier drivers. This removes their "route to and report formatting" behavior. Instead, it now only reports formatting without routing the cursor. * Address review actions. * Update user docs. * Add the report text formatting under braille cell command to the EuroBraille displays. * Revert browseable message for the report text formatting under braille cell command. * Incorporate PR #7990. * Add translator comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7869
Summary of the issue:
When pressing the reportFormatting script multiple times, such as for showing the formatting in browseMode, the formatting can be different from the first time you press it.
The reason is that code in the reportFormatting script (or code it calls) may mutate the TextInfo such as expanding to line etc. Which then means that asking for the formatting is asking for a different position.
The reviewPosition could be copied before fetching formatting.
Description of how this pull request fixes the issue:
The reportFormatting script now makes sure to copy the reviewPosition first.
Testing performed:
Followed the steps to reproduce in #7869 with success.
Known issues with pull request:
Change log entry:
Bug fixes: