Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get reliable points from offsets in virtual buffers #8479

Merged
merged 26 commits into from
Aug 20, 2018
Merged

Get reliable points from offsets in virtual buffers #8479

merged 26 commits into from
Aug 20, 2018

Commits on Jul 20, 2018

  1. Add the ia2StartOffset to a Gecko TextFieldNode if that node originat… 

    …es from IA2Text. Thanks to @jcsteh
    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    fc46d4b View commit details
    Browse the repository at this point in the history

  2. Add helper methods to get raw nodes from a buffer

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    fea0cfe View commit details
    Browse the repository at this point in the history

  3. Fix VirtualBuffer._getControlFieldAttribs to search for attributes wi… 

    …thin the control field.
    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    8f06d96 View commit details
    Browse the repository at this point in the history

  4. When characters are stripped from a TextFieldNode, add an additional … 

    …attribute to the node that indicates this
    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    2d970f9 View commit details
    Browse the repository at this point in the history

  5. Add unit for text fields and use that instead of new helper functions

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    39a4433 View commit details
    Browse the repository at this point in the history

  6. Implement pointFromOffset for GECKO

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    ee3d1c6 View commit details
    Browse the repository at this point in the history

  7. Raise a LookupError when no identifier could be retrieved from an offset

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    200309c View commit details
    Browse the repository at this point in the history

  8. Improve pointFromOffset in Adobe Reader as well

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    b216bc8 View commit details
    Browse the repository at this point in the history

  9. Also implement getOffsetFromPoint for gecko

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    5eaa545 View commit details
    Browse the repository at this point in the history

  10. Fall back to the base implementation for point from offset when Adobe… 

    … reader objects don't expose a location
    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    6202999 View commit details
    Browse the repository at this point in the history

  11. Raise LookupError before the base implementation for getting points f… 

    …rom offsets in virtual buffers tries to iterate over the None location of an object
    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    eac351f View commit details
    Browse the repository at this point in the history

  12. Change an assertion for TextInfo into an if check which is more safe

    Leonard de Ruijter committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    a6fca0b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. Review actions

    Leonard de Ruijter committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    20ec3c9 View commit details
    Browse the repository at this point in the history

  2. Hopefully made checking stripped chars from start of text field nodes… 

    … more robust
    Leonard de Ruijter committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    cc7d31f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Merge remote-tracking branch 'origin/master' into geckoPointFromOffset

    Leonard de Ruijter committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    9a6ff30 View commit details
    Browse the repository at this point in the history

  2. Revert change to getControlFieldAttribs

    Leonard de Ruijter committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    ec626a0 View commit details
    Browse the repository at this point in the history

  3. Revert the addition of _getOffsetFromPoint for Gecko virtual buffers

    Leonard de Ruijter committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    0202412 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Review action

    Leonard de Ruijter committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    72cf1fa View commit details
    Browse the repository at this point in the history

  2. Make use of locationHelper within the adobe reader VBuf pyuthon code

    Leonard de Ruijter committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    99d3d02 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Use the center of bounding rectangles for Gecko

    Leonard de Ruijter committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    c19970e View commit details
    Browse the repository at this point in the history

  2. Restored brackets, no functional change

    Leonard de Ruijter committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    ac67fe8 View commit details
    Browse the repository at this point in the history

  3. Edited changes.t2t

    Leonard de Ruijter committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    9c9945e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Use locationHelper to calculate a center point from character extends

    Leonard de Ruijter committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    c17223e View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Revert "Edited changes.t2t" 

    This reverts commit 9c9945e.
    Leonard de Ruijter committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    2bc4709 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into geckoPointFromOffset

    Leonard de Ruijter committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    c1b0e31 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Update changes file for PR #8479

    @feerrenrut
    feerrenrut authored Aug 20, 2018
    Configuration menu
    Copy the full SHA
    d215ef7 View commit details
    Browse the repository at this point in the history