fix windows support #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenmeade
approved these changes
Dec 17, 2023
|
@haydenmeade done, thanks. |
|
this is very relevant and necessary. How are things progressing on this issue? |
|
in my opinion, the second point does not work
|
|
@bad4iz Thanks for the report, i updated my dependencies and it seems that the second point was fixed in another place (probably in the neotest repo) and now the original test id respects the drive case, so the windows specific hack is no longer needed. I removed it and everything seems to be working as expected again. |
|
yes it works. thanks |
|
@haydenmeade this is very relevant and necessary. How are things progressing on this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin in windows has 2 issues:
\instead of/in the file path. #422) After solving the first issue i noticed that neotest doesn't update the sign for each test making every test appear with an X even if the test passed. This is caused due to the test having an id likeIt seems that neotest now respects the case of the test id so this is no longer an issue.c:\\path\file::test_nameand the Jest output reports the path likeC:\\path\file::test_name(notice the capital drive)This PR attemps to solve both issues.
First issue was solved using
vim.fs.normalizeas recommended in #44 (comment).Second issue was solved adding a windows only validation that changes the case of the drive.Tested in windows everything works as expected. Should not cause any issue in other platforms.
Fixes #42
Supersedes #44