fix: use nil for the default diagnostics severity #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neovim/neovim#24736 has introduced a new syntax for severity format in `vim.diagnostic.get()`. Fix #2661
Conni2461
previously requested changes
Aug 24, 2023
jamestrew
approved these changes
Sep 3, 2023
jamestrew
dismissed
Conni2461’s stale review
requested changes applied. tested on both nightly and 0.9
Conni2461
pushed a commit
that referenced
this pull request
Sep 5, 2023
* fix: use nil for the default diagnostics severity neovim/neovim#24736 has introduced a new syntax for severity format in `vim.diagnostic.get()`. Fix #2661 * fix: fallback for 0.9.1 * fix: detect changes only when minor version > 9 (cherry picked from commit 6b79d7a)
rameshsanth
pushed a commit
to rameshsanth/telescope.nvim
that referenced
this pull request
Nov 17, 2023
* fix: use nil for the default diagnostics severity neovim/neovim#24736 has introduced a new syntax for severity format in `vim.diagnostic.get()`. Fix nvim-telescope#2661 * fix: fallback for 0.9.1 * fix: detect changes only when minor version > 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
neovim/neovim#24736 has introduced a new syntax for severity format in
vim.diagnostic.get().Fix #2661
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
:Telescope diagnosticsat a file with diagnostic warnings.Configuration:
Checklist: