Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(previewer): improve file_maker line splitting and timeouts #3261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamestrew
Copy link
Contributor

@jamestrew jamestrew commented Aug 18, 2024

Previous method of splitting files into lines and incorporating a timer is sub-optimal in two ways

By avoiding using vim.gsplit, we can avoid some overheads it needs to account for patterns and options, and we can check for timeouts more incrementally (every 200 bytes) to avoid getting caught up in huge singular lines.

Based on quick and dirty benchmarks against large-ish files in the issue above, I'm seeing about a 4-5x speed increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant