Potential 0.40.0 regression on Github Actions runners #3405
Comments
|
Do you (fwiw, i use nvm 0.40.0 in my own ljharb/actions, which runs on 500 of my projects, and these don't fail, so I'm trying to figure out what might have changed here) |
|
Here's a similar actions failing - i've added Full output: I wonder if the difference is that your projects might have |
|
Adding onto my previous comment, I think there might be a bug / edge case with In my github action I did The final working command for reference: |
|
hmm, it looks like it's getting |
The issue is definitely happening only when there is an .nvmrc present. I ran bash in debug mode (-xv), and I believe it was failing when trying to parse it. It seems that 0.40.0 added comments support to .nvmrc, so it sounds like it might be a regression root (not confident). I will add -xv back post the output when I'm back to this. |
I don't think I use -e anywhere (see the test workflow I've created to reproduce this issue. It's super simple) DetailsEdit: updated the run to match the install |
@ljharb Does it mean it uses iojs as default (unlike node) or am I misreading the debug? |
|
ok, so the default options in that workflow are The github action workflow was and will be very helpful here, both for repro, investigation, and later for a regression test. |
|
@AutomationD yeah, you're misreading it - that's just a predicate to determine if v18 is an iojs version (which it's not, ofc). |
Great find, thanks for looking into it! At this point I'll be locking my nvm workflows and a wrapper using nvm to version |
|
ok, some bisecting suggests the issue was introduced in #2869: https://github.com/ljharb/ize/actions/runs/10328344009 I've got a fix; I'll adapt the workflows into a regression test |
|
I ran into this issue and spent a while narrowing it down to the nvm version before finding this thread, but here's my regression workflow that shows some difference between name: Test NVMs NVM_DIR on ubuntu-latest
on:
workflow_dispatch:
defaults:
run:
shell: bash
env:
UNAUTO_NODE_VERSION: v18.18.2 # "NODE_VERSION" is read by the nvm install script.
SETX: "false"
jobs:
nvmrc-present-older-nvm:
strategy:
fail-fast: false
matrix:
nvm-version: ['v0.39.5', 'v0.39.6', 'v0.39.7', 'v0.40.0']
runs-on: ubuntu-latest
steps:
- run: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/${{ matrix.nvm-version }}/install.sh | bash
- run: echo "$UNAUTO_NODE_VERSION" > .nvmrc
- if: env.SETX == 'true'
run: source <(echo "set -x"; cat $NVM_DIR/nvm.sh; echo "set +x") && nvm install $(cat .nvmrc)
- if: env.SETX != 'true'
run: source $NVM_DIR/nvm.sh && nvm install $(cat .nvmrc)
nvmrc-present-default-nvm: # v0.40.0 atm
runs-on: ubuntu-latest
steps:
- run: echo "$UNAUTO_NODE_VERSION" > .nvmrc
- if: env.SETX == 'true'
run: source <(echo "set -x"; cat $NVM_DIR/nvm.sh; echo "set +x") && nvm install $(cat .nvmrc)
- if: env.SETX != 'true'
run: source $NVM_DIR/nvm.sh && nvm install $(cat .nvmrc)
nvmrc-absent-default-nvm: # v0.40.0 atm
runs-on: ubuntu-latest
steps:
- run: source $NVM_DIR/nvm.sh && nvm install $UNAUTO_NODE_VERSION |
Welcome to the family 🤗 Hopefully @ljharb will release a fix soon. |
|
Prior to some fix that may take some time to percolate onto the runner (and not wanting to frob the installed version), besides swallowing any other arbitrary error, is temporarily renaming the |
The only workaround I know is downgrading to |
13 tasks
|
The trivial workaround in the meantime is |
|
My solution was to remove NVM from Exit code 3 was not great. |
How did you use |
NVM got installed through a third party action at the beginning, such as The rest of our actions do not require node or nvm and do not explicitly install nvm. This issue should affect anyone doing something similar: setting |
|
Unfortunately I was able to create solid regression tests, but they exposed they my fix wasn't complete, and I'm still working on that fix. |
thisconnect
added a commit
to thisconnect/bitbox-wallet-app
that referenced
this issue
Aug 19, 2024
Downgrading to nvm v0.39.7, see this issue: - nvm-sh/nvm#3405 Homebrew installation is not supported, see: - https://github.com/nvm-sh/nvm?tab=readme-ov-file#important-notes
thisconnect
added a commit
to thisconnect/bitbox-wallet-app
that referenced
this issue
Aug 19, 2024
Downgrading to nvm v0.39.7, see this issue: - nvm-sh/nvm#3405 Homebrew installation is not supported, see: - https://github.com/nvm-sh/nvm?tab=readme-ov-file#important-notes
|
got it! I'm going to try to squeeze in one more bugfix, and I'll have a patch release out tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Poential 0.40.0 regression in Github Actions CI/CD
I tried to fill out the form, but it's quite hard as most things simply don't run.
Here is a set of test workflows that show the regression.
Operating system and version:
Ubuntu 22.04
(Github Runner version 20240804.1.0)
nvm debugoutput:# Impossible to run directlynvm lsoutput:# Impossible to run directlyHow did you install
nvm?Pre-installed on Github Runner
What steps did you perform?
What happened?
Received output:
What did you expect to happen?
Install of the node version specified in .nvmrc (
18)Is there anything in any of your profile files that modifies the
PATH?I don't think so. It's a fresh Github Action runner
If you are having installation issues, or getting "N/A", what does
curl -I --compressed -v https://nodejs.org/dist/print out?Please see workflow runs for demonstration of the apparent regression,
curl -I --compressed -v https://nodejs.org/dist/ % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* Trying 104.20.22.46:443... * Connected to nodejs.org (104.20.22.46) port 443 (#0) * ALPN, offering h2 * ALPN, offering http/1.1 * CAfile: /etc/ssl/certs/ca-certificates.crt * CApath: /etc/ssl/certs * TLSv1.0 (OUT), TLS header, Certificate Status (22): } [5 bytes data] * TLSv1.3 (OUT), TLS handshake, Client hello (1): } [512 bytes data] * TLSv1.2 (IN), TLS header, Certificate Status (22): { [5 bytes data] * TLSv1.3 (IN), TLS handshake, Server hello (2): { [122 bytes data] * TLSv1.2 (IN), TLS header, Finished (20): { [5 bytes data] * TLSv1.2 (IN), TLS header, Supplemental data (23): { [5 bytes data] * TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8): { [19 bytes data] * TLSv1.3 (IN), TLS handshake, Certificate (11): { [4835 bytes data] * TLSv1.3 (IN), TLS handshake, CERT verify (15): { [520 bytes data] * TLSv1.3 (IN), TLS handshake, Finished (20): { [52 bytes data] * TLSv1.2 (OUT), TLS header, Finished (20): } [5 bytes data] * TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1): } [1 bytes data] * TLSv1.2 (OUT), TLS header, Supplemental data (23): } [5 bytes data] * TLSv1.3 (OUT), TLS handshake, Finished (20): } [52 bytes data] * SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384 * ALPN, server accepted to use h2 * Server certificate: * subject: CN=*.nodejs.org * start date: Feb 28 00:00:00 2024 GMT * expire date: Mar 30 23:59:59 2025 GMT * subjectAltName: host "nodejs.org" matched cert's "nodejs.org" * issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA * SSL certificate verify ok. * Using HTTP2, server supports multiplexing * Connection state changed (HTTP/2 confirmed) * Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0 * TLSv1.2 (OUT), TLS header, Supplemental data (23): } [5 bytes data] * TLSv1.2 (OUT), TLS header, Supplemental data (23): } [5 bytes data] * TLSv1.2 (OUT), TLS header, Supplemental data (23): } [5 bytes data] * Using Stream ID: 1 (easy handle 0x56543f0b8e20) * TLSv1.2 (OUT), TLS header, Supplemental data (23): } [5 bytes data] > HEAD /dist/ HTTP/2 > Host: nodejs.org > user-agent: curl/7.81.0 > accept: */* > accept-encoding: deflate, gzip, br, zstd > * TLSv1.2 (IN), TLS header, Supplemental data (23): { [5 bytes data] * TLSv1.3 (IN), TLS handshake, Newsession Ticket (4): { [230 bytes data] * TLSv1.3 (IN), TLS handshake, Newsession Ticket (4): { [230 bytes data] * old SSL session ID is stale, removing * TLSv1.2 (IN), TLS header, Supplemental data (23): { [5 bytes data] * TLSv1.2 (OUT), TLS header, Supplemental data (23): } [5 bytes data] * TLSv1.2 (IN), TLS header, Supplemental data (23): { [5 bytes data] * TLSv1.2 (IN), TLS header, Supplemental data (23): { [5 bytes data] < HTTP/2 200 < date: Thu, 08 Aug 2024 12:30:09 GMT < content-type: text/html < cache-control: public, max-age=3600, s-maxage=14400 HTTP/2 200 date: Thu, 08 Aug 2024 12:30:09 GMT content-type: text/html cache-control: public, max-age=3600, s-maxage=14400 last-modified: Thu, 08 Aug 2024 11:05:18 GMT cf-cache-status: HIT age: 4469 vary: Accept-Encoding strict-transport-security: max-age=31536000; includeSubDomains; preload x-content-type-options: nosniff server: cloudflare cf-ray: 8aff841c88317d52-LAX content-encoding: br < last-modified: Thu, 08 Aug 2024 11:05:18 GMT < cf-cache-status: HIT < age: 4469 < vary: Accept-Encoding < strict-transport-security: max-age=31536000; includeSubDomains; preload < x-content-type-options: nosniff < server: cloudflare < cf-ray: 8aff841c88317d52-LAX < content-encoding: br < 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 * Connection #0 to host nodejs.org left intact % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left SpeedThe text was updated successfully, but these errors were encountered: