Rewrite installation code path #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
installing node
| @@ -12,8 +22,11 @@ install: | |||
| - chmod +x /tmp/urchin/package/urchin | |||
| - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y' | |||
| script: | |||
| - export CXX=g++-4.8 | |||
| - export CC=gcc-4.8 | |||
There was a problem hiding this comment.
You can probably use env here.
There was a problem hiding this comment.
Then I'd have to define it once for each matrix item, instead of once for the entire build.
There was a problem hiding this comment.
env:
global:
- CXX=g++-4.8
- CC=gcc-4.8Works as well.
https://docs.travis-ci.com/user/environment-variables/#Global-Variables
There was a problem hiding this comment.
Wow, thanks, that's great. I'll use that.
Closed
ljharb
force-pushed
the
iojs_source
branch
7 times, most recently
from
e9ac951
to
dcfa63f
Compare
- consolidate `nvm_install_merged_node_binary` with `nvm_install_node_binary` - add `nvm_get_download_slug`, `nvm_download_artifact` - `nvm uninstall` no longer removes artifacts
- `nvm uninstall` no longer removes source artifacts
…g, io.js too. - `nvm_get_checksum` now accepts 5 args (from 3): flavor (node/iojs), type (binary/source), version, slug, compression (xz/gz) - `nvm_install_binary` accepts 3 args (from 2): flavor (node/iojs), kind (std), version - remove `nvm_install_iojs_binary`
- cache the nvm cache on travis
- consolidate `nvm_install_iojs_source` and `nvm_install_node_source` into `nvm_install_source`
This was referenced Sep 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the entire installation code path for nvm. This allows:
io.jsinstallation from sourcenodev4+ installation from sourcenvm cachecommands to manage cached archivesinstallation_iojssource tests are disabled, because they take too long in travis-ci to complete. I find this acceptable because the existing "install from source" code path is tested, and enough code is now shared that the risk is quite low.Fixes #1188. Fixes #1193. Fixes #700. Obviates #1192. Unblocks #1053 & #779.