Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing the shell prompt to display the current Node.js version #3426

Closed
wants to merge 8 commits into from

Conversation

srinivas365
Copy link

  1. Included functionality for customizing the shell prompt to display the current Node.js version.
Screenshot 2024-09-16 at 3 23 28 PM

@srinivas365 srinivas365 changed the title Add Node.js Version Prompt Customization to NVM Installation Script Customizing the shell prompt to display the current Node.js version Sep 16, 2024
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In no way is this something the install script should do - modifying the shell prompt is very intrusive, and it would almost certainly break someone’s existing custom prompt.

Also, it doesn’t require nearly this many lines of code to add the node version to the prompt - my shell profile file does it in 2-3 lines.

@ljharb ljharb marked this pull request as draft September 16, 2024 12:38
@ljharb ljharb added the feature requests I want a new feature in nvm! label Sep 16, 2024
@ljharb ljharb closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature requests I want a new feature in nvm!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants