Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafely downcast INTEGER to INTEGER*4 when used in arithmetic GOTO #179

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

jeffhammond
Copy link
Collaborator

This is necessary to address #177.

@jeffhammond
Copy link
Collaborator Author

This is not the only fix required. Less trivial fixes are required to e.g. NWints/ints_sp/sinfo.F, which are not implemented yet.

@edoapra
Copy link
Collaborator

edoapra commented Feb 13, 2020

@jeffhammond thanks for sending this fix to geom_hnd.F
I have forgot to bring it from the box where I have been using aocc 2.1.0
I will check in the sinfo.F fix after merging this pull

@edoapra edoapra merged commit 323447f into nwchemgit:master Feb 13, 2020
Copy link
Collaborator

@edoapra edoapra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants