[nw13beta2] Crash when using devtools to view source #4121

maxbarry · 2015-12-31T04:31:38Z

nwjs-sdk-v0.13.0-beta2-linux-x64 experiences a fatal crash on Ubuntu 15.10 when clicking a link in devtools to view the source of a custom module included with nw.require().

To reproduce:

Start nwjs: nwjs-sdk-v0.13.0-beta2-linux-x64/nw
Open devtools by right-clicking in window and selecting "Inspect".
Require a custom module, e.g. var m = nw.require('/home/max/code/myApp/js/Game'). (The problem also occurs when requiring a custom module via a relative path, e.g. var m = nw.require('./js/Game'))
If there's an error in the module, the devtools console will display a line like: Uncaught ReferenceError {message: "myTestThing is not defined"} /home/max/code/myApp/js/Game.js:31
Similarly, the module might produce output via console.log().
Clicking the underlined filename:lineNumber above in order to view the source code crashes everything (dev tools + app). The command line displays:

[5482:5482:1231/150908:FATAL:browser_view.cc(530)] Check failed: browser->is_type_popup(). opening browser window.
#0 0x7f726e52852e <unknown>

Aborted

Notably, this only happens when clicking a link that displays the module's full pathname. In some contexts, only the filename is shown instead (e.g. "Game.js:31"), and in these cases, hovering over it pops up a link like "chrome-extension://bdmasdoiqaslfdkhjasfhsda/js/Game.js", and I can click it to successfully navigate to view its source. However, when the full pathname is displayed, hovering will pop up a link like "chrome-devtools://devtools/home/max/code/myApp/js/Game.js", and clicking it will always produce a crash.

The text was updated successfully, but these errors were encountered:

rogerwang · 2016-01-05T03:10:00Z

Could you please upload your sample for this?

maxbarry · 2016-01-05T03:42:15Z

console.log("hello");

If that code is /home/max/myModule.js, I can get a crash by running nwjs-sdk-v0.13.0-beta2-linux-x64/nw (with no arguments), opening devtools with Right-Click -> Inspect Background page, and typing var m = nw.require('/home/max/myModule.js') into the devtools console.

It then displays:

hello                                         /home/max/myModule.js:1

... and crashes when I click that link "/home/max/myModule.js:1".

maxbarry · 2016-01-05T03:52:13Z

Here is another way to do it:

package.json:

{
  "name": "sample",
  "main": "index.html"
}

index.html:

<!DOCTYPE html>
<html>
  <head>
    <title>Hello World!</title>
  </head>
  <body>
    <h1>Hello World!</h1>
    <script>
    nw.require('./myModule.js');
    </script>
  </body>
</html>

myModule.js:

console.log("hello");

To reproduce:

nwjs-sdk-v0.13.0-beta2-linux-x64/nw .
See "Hello World!" HTML page
Right-click -> Inspect background page
See console output: hello /home/max/myModule.js:1
Click link above to myModule.js

Command-line displays:

[10666:10666:0105/144647:FATAL:browser_view.cc(530)] Check failed: browser->is_type_popup(). opening browser window.
#0 0x7f39436a352e <unknown>

Aborted

rogerwang · 2016-01-06T01:58:35Z

With the latest nightly build it shouldn't crash any more, but the pointed URL is not found. @ghostoy could you look into this?

ghostoy · 2016-01-06T05:07:40Z

It doesn't crash but popup a new window looks like this:

rogerwang · 2016-01-06T05:36:34Z

I knew it looks like this ... I mean could you please look to fix it?

ghostoy · 2016-01-06T06:59:24Z

Yeah. I'll take a look at this issue.

gwicksted · 2016-01-06T17:25:53Z

(related?) Crashes (for real) if you click on "module.js" link from Devtools console when it shows an error related to loading a module (eg if the module was not found). Let me know if this should be a new issue.

Currently the Node context is created within the context of background page. Reset the debugger id will cause debugger filter out the compiled script from Node. Fixed nwjs#4121

In separate mode, the Node context is created within the context of background page. Overwrite the debugger id will cause debugger filter out the compiled scripts from Node. Fixed nwjs#4121

test case for issue #4121

maxbarry · 2016-01-18T23:33:40Z

Not sure this is fixed. I get the same (crash) result from the same action with a slightly different test case in beta4.

package.json:

{
  "name": "sample",
  "main": "index.html"
}

index.html:

<!DOCTYPE html>
<html>
  <head>
    <title>Hello World!</title>
  </head>
  <body>
    <h1>Hello World!</h1>
    <script src="myModule.js"></script>
  </body>
</html>

myModule.js:

console.log("Loading myModule2...");

nw.require('./myModule2');

myModule2.js:

myTestError();

To reproduce:

Run nwjs-sdk-v0.13.0-beta4-linux-x64/nw .
Right-click on window and select "Inspect"
Click to view Console. (It doesn't start in console by default any more?)
See two lines of output:

Loading myModule2...         myModule.js:1 
Uncaught ReferenceError: myTestError is not defined    /home/max/code/sports/test2/myModule2.js:1

Clicking the first line of output ("Loading myModule2.js...") does work, kind of: It takes me to the source of myModule.js, although it forgets which line number it's supposed to be showing (instead of scrolling to and highlighting the right one).

Clicking the "Uncaught ReferenceError" line produces the same crashing error as before:

[9837:9837:0119/101658:FATAL:browser_view.cc(533)] Check failed: browser->is_type_popup(). opening browser window.
#0 0x7fae84f450ee <unknown>

Aborted

rogerwang · 2016-01-19T01:11:29Z

@ghostoy pls follow up.

rogerwang · 2016-01-20T05:03:00Z

Fixed in git and will be available in the next nightly build.

By default, the disposition is `NEW_FOREGROUND_TAB`, which will be opened in a browser tab. Fixed nwjs/nw.js#4269 nwjs/nw.js#4121

rogerwang self-assigned this Dec 31, 2015

rogerwang added the test-todo label Jan 5, 2016

rogerwang added the nw13 label Jan 6, 2016

rogerwang assigned ghostoy and unassigned rogerwang Jan 6, 2016

ghostoy mentioned this issue Jan 7, 2016

Remove debugger id index for Node #4182

Merged

rogerwang closed this as completed in #4182 Jan 7, 2016

ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Jan 13, 2016

test case for issue nwjs#4121

33a5999

ghostoy removed the test-todo label Jan 13, 2016

ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Jan 14, 2016

test case for issue nwjs#4121

409c22a

rogerwang added a commit that referenced this issue Jan 14, 2016

Merge pull request #4226 from ghostoy/issue-4121

323b4a4

test case for issue #4121

offshore mentioned this issue Jan 18, 2016

nwjs 0.13 beta3 - devtools / app crash when clicking links from console #4256

Closed

maxbarry mentioned this issue Jan 18, 2016

0.13 beta4 - devtools / source not found when clicking links from console #4269

Open

rogerwang reopened this Jan 19, 2016

rogerwang closed this as completed Jan 20, 2016

rogerwang pushed a commit to nwjs/chromium.src that referenced this issue Feb 19, 2016

Change default disposition to NEW_POPUP for urls opened by app

89324ba

By default, the disposition is `NEW_FOREGROUND_TAB`, which will be opened in a browser tab. Fixed nwjs/nw.js#4269 nwjs/nw.js#4121

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nw13beta2] Crash when using devtools to view source #4121

[nw13beta2] Crash when using devtools to view source #4121

maxbarry commented Dec 31, 2015

rogerwang commented Jan 5, 2016

maxbarry commented Jan 5, 2016

maxbarry commented Jan 5, 2016

rogerwang commented Jan 6, 2016

ghostoy commented Jan 6, 2016

rogerwang commented Jan 6, 2016

ghostoy commented Jan 6, 2016

gwicksted commented Jan 6, 2016

maxbarry commented Jan 18, 2016

rogerwang commented Jan 19, 2016

rogerwang commented Jan 20, 2016

[nw13beta2] Crash when using devtools to view source #4121

[nw13beta2] Crash when using devtools to view source #4121

Comments

maxbarry commented Dec 31, 2015

rogerwang commented Jan 5, 2016

maxbarry commented Jan 5, 2016

maxbarry commented Jan 5, 2016

rogerwang commented Jan 6, 2016

ghostoy commented Jan 6, 2016

rogerwang commented Jan 6, 2016

ghostoy commented Jan 6, 2016

gwicksted commented Jan 6, 2016

maxbarry commented Jan 18, 2016

rogerwang commented Jan 19, 2016

rogerwang commented Jan 20, 2016