fix(get): yauzl-promise unzipping on MacOS
#1017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The workaround is not working, the issue could be in how |
ayushmanchhabra
force-pushed
the
fix/unzip-macos
branch
from
3271ce8
to
84cd7ce
Compare
|
The issue is with the current https implementation. Addressing that in GH-1019 |
ayushmanchhabra
pushed a commit
that referenced
this pull request
Jan 31, 2024
### Description of Changes - Use both absolute and relative paths for the cache directory. - Fixes the issue on MacOS related to the existence of a cache folder that is not present in the same current directory. - Correctly unzips files in MacOs. Notes: Resolves issued caused by cache is in a directory other than the current path. Closes: #1017
ayushmanchhabra
pushed a commit
that referenced
this pull request
Feb 1, 2024
🤖 I have created a release *beep* *boop* --- ## [4.6.0](v4.5.4...v4.6.0) (2024-02-01) ### Features * **get:** set `cacheDir` on another volume ([#1023](#1023)) ([7c0f711](7c0f711)), closes [#1017](#1017) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes