Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(get): set cacheDir on another volume #1023

Merged
merged 4 commits into from
Jan 31, 2024
Merged

feat(get): set cacheDir on another volume #1023

merged 4 commits into from
Jan 31, 2024

Conversation

jorisdugue
Copy link
Contributor

@jorisdugue jorisdugue commented Jan 30, 2024 •
edited by ayushmanchhabra
Loading

Description of Changes

  • Use both absolute and relative paths for the cache directory.
  • Fixes the issue on MacOS related to the existence of a cache folder that is not present in the same current directory.
  • Correctly unzips files in MacOs.

Notes: Resolves issued caused by cache is in a directory other than the current path.

Closes: #1017

@ayushmanchhabra
Copy link
Collaborator

I'm getting the same error in GH-1017. If you're able to resolve this error, that's be great. 🙏🏼

@ayushmanchhabra
Copy link
Collaborator

Weird that there's a lint error on Windows runner image only. Running npm run lint:fix and commiting the changes should fix it.

@ayushmanchhabra ayushmanchhabra changed the title chore(get): allow to using cache dir to another disk feat(get): set cacheDir on another disk Jan 31, 2024
@ayushmanchhabra ayushmanchhabra changed the title feat(get): set cacheDir on another disk feat(get): set cacheDir on another volume Jan 31, 2024
@ayushmanchhabra
Copy link
Collaborator

I'm good to merge this in but before I do, I have a few questions regarding implementation.

@ayushmanchhabra ayushmanchhabra merged commit 7c0f711 into nwutils:main Jan 31, 2024
3 checks passed
@jorisdugue
Copy link
Contributor Author

What questions do you have? @ayushmanchhabra

Additionally, it's worth mentioning that when working on Windows and wanting to create symbolic links, administrative privileges are necessary. Alternatively, you might consider using mlink, as it doesn't demand administrator rights.

@ayushmanchhabra
Copy link
Collaborator

What questions do you have? @ayushmanchhabra

Additionally, it's worth mentioning that when working on Windows and wanting to create symbolic links, administrative privileges are necessary. Alternatively, you might consider using mlink, as it doesn't demand administrator rights.

@jorisdugue I've asked them above.

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
ayushmanchhabra pushed a commit that referenced this pull request Feb 1, 2024
@github-actions
chore(main): release 4.6.0 (#1024)
4ab7b8d 
🤖 I have created a release *beep* *boop*
---


##
[4.6.0](v4.5.4...v4.6.0)
(2024-02-01)


### Features

* **get:** set `cacheDir` on another volume
([#1023](#1023))
([7c0f711](7c0f711)),
closes [#1017](#1017)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushmanchhabra ayushmanchhabra Awaiting requested review from ayushmanchhabra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisdugue @ayushmanchhabra