Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN_US is not defined #1125

Closed
hohnworld opened this issue Jun 18, 2024 · 2 comments · Fixed by #1127 or #1121
Closed

EN_US is not defined #1125

hohnworld opened this issue Jun 18, 2024 · 2 comments · Fixed by #1127 or #1121

Comments

@hohnworld
Copy link

{
"name": "nw-demo",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"start": "nw src/",
"build": "nwbuild --glob=false src"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"nw": "0.85.0"
}
}
C:\Users\Administrator\Desktop\demo\nw-demo>npm run build

[email protected] build
nwbuild --glob=false src

ReferenceError: EN_US is not defined
at setWinConfig (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:335:45)
at async bld (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:185:5)
at async nwbuild (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/index.js:116:7)
node:internal/process/promises:289
nw-demo.zip

        triggerUncaughtException(err, true /* fromPromise */);
        ^

ReferenceError: EN_US is not defined
at setWinConfig (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:335:45)
at async bld (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:185:5)
at async nwbuild (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/index.js:116:7)

Node.js v20.14.0

nw-demo.zip

@ayushmanchhabra
Copy link
Collaborator

Fix will be to move this line

EN_US,

above this line

if (app.icon) {

@ayushmanchhabra
Copy link
Collaborator

Afk so can't do it myself right now, open to PR

ayushmanchhabra pushed a commit that referenced this issue Jun 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.7.6](v4.7.5...v4.7.6)
(2024-06-19)


### Bug Fixes

* **bld:** resolve undefined reference
([#1127](#1127))
([006b517](006b517)),
closes [#1125](#1125)


### Chores

* **deps-dev:** bump @stylistic/eslint-plugin-js from 2.1.0 to 2.2.1 in
the npm group
([#1123](#1123))
([fcd83a9](fcd83a9))
* **deps-dev:** bump ws from 8.17.0 to 8.17.1
([#1126](#1126))
([7aa6f08](7aa6f08))
* **deps:** bump actions/checkout from 4.1.6 to 4.1.7 in
/.github/workflows in the gha group
([#1116](#1116))
([eefde68](eefde68))
* **test:** enable e2e tests
([#1120](#1120))
([f802947](f802947))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants