Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(get): refactor implementation #1025

Merged
merged 8 commits into from
Feb 3, 2024
Merged

chore(get): refactor implementation #1025

merged 8 commits into from
Feb 3, 2024

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Feb 2, 2024

Description of Changes

  • Use internal APIs such as request, decompress, ffmpeg, node and nw functions.

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review February 3, 2024 01:12
@ayushmanchhabra ayushmanchhabra changed the title chore(get): refactor get impl chore(get): refactor get implementation Feb 3, 2024
@ayushmanchhabra ayushmanchhabra changed the title chore(get): refactor get implementation chore(get): refactor implementation Feb 3, 2024
@ayushmanchhabra ayushmanchhabra merged commit 72f65e1 into main Feb 3, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the refactor/get branch February 3, 2024 03:31
ayushmanchhabra pushed a commit that referenced this pull request Feb 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.6.1](v4.6.0...v4.6.1)
(2024-02-15)


### Chores

* **ci:** add chores section to changelog
([#1028](#1028))
([d630720](d630720))
* **ci:** fixup release please action
([#1032](#1032))
([f9ae7cd](f9ae7cd))
* **ci:** remove `schema` prop
([33238b1](33238b1))
* **deps:** bump the gha group in /.github/workflows with 1 update
([70030df](70030df))
* **docs:** update PR template to simplify commit descriptions
([#1029](#1029))
([6da9b89](6da9b89))
* **docs:** update readme and changelog
([63fd50b](63fd50b))
* fix remaining lint errors
([334ae74](334ae74))
* **get:** refactor implementation
([#1025](#1025))
([72f65e1](72f65e1))
* **get:** refactor unzip symlink implementation
([#1030](#1030))
([69661c3](69661c3))
* **get:** simplify symlink logic
([#1035](#1035))
([4f64307](4f64307)),
closes [#1030](#1030)
* **release-please-action:** do not point to manifest file
([96eeec8](96eeec8))
* **release-please-action:** point to config and manifest
([0a6a44d](0a6a44d))
* **release-please:** correct path to package
([3719cee](3719cee))
* **release-please:** remove manifest
([23a16fb](23a16fb))
* **run:** mark run mode as deprecated
([#1027](#1027))
([1115728](1115728))
* **test:** try adding chores to release notes
([#1031](#1031))
([5cabc20](5cabc20))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ayushmanchhabra
Copy link
Collaborator Author

This actually fixes cache behaviour but the commit message does not capture this info.

Refs: #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant