Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(get): copy ffmpeg to correct location on windows #1044

Merged
merged 1 commit into from
Feb 24, 2024
Merged

fix(get): copy ffmpeg to correct location on windows #1044

merged 1 commit into from
Feb 24, 2024

Conversation

zkrige
Copy link
Collaborator

@zkrige zkrige commented Feb 24, 2024 •
edited by ayushmanchhabra
Loading

  • Windows FFmpeg copy was breaking because the destination path was never set

@zkrige
Copy link
Collaborator Author

zkrige commented Feb 24, 2024

this is tested working on windows builds. Previous it was failing on windows with error

@ayushmanchhabra ayushmanchhabra changed the title fix: windows destination for ffmpeg copy fix(get): copy ffmpeg to correct location on windows Feb 24, 2024
@ayushmanchhabra ayushmanchhabra merged commit 71fa4ab into main Feb 24, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the windows-ffmpeg-copy-path branch February 24, 2024 16:32
@github-actions github-actions bot mentioned this pull request Feb 24, 2024
Merged
ayushmanchhabra pushed a commit that referenced this pull request Feb 24, 2024
@github-actions
chore(main): release 4.6.4 (#1045)
f919b8b 
🤖 I have created a release *beep* *boop*
---


##
[4.6.4](v4.6.3...v4.6.4)
(2024-02-24)


### Bug Fixes

* **get:** copy ffmpeg to correct location on windows
([#1044](#1044))
([71fa4ab](71fa4ab))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushmanchhabra ayushmanchhabra ayushmanchhabra approved these changes

Assignees

@zkrige zkrige

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkrige @ayushmanchhabra