Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bld): remove repetitive code for updating MacOS Helper apps #1214

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

sysrage
Copy link
Contributor

@sysrage sysrage commented Aug 24, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.55% 578 / 1832
🔵 Statements 31.55% 578 / 1832
🔵 Functions 31.03% 9 / 29
🔵 Branches 63.33% 19 / 30
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/bld/osx.js 12.69% 100% 0% 12.69% 15-23, 34-189
Generated in workflow #876

@ayushmanchhabra ayushmanchhabra changed the title remove repetitive code for macOS helper renames chore(bld): remove repetitive code for updating MacOS Helper apps Aug 24, 2024
@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Aug 24, 2024

@sysrage Thanks for this.. could you revert destructuring the imports please?

@ayushmanchhabra ayushmanchhabra merged commit e1edc05 into main Aug 24, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the fix/remove-repetitive-code branch August 24, 2024 19:51
ayushmanchhabra pushed a commit that referenced this pull request Sep 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.11.0](v4.10.0...v4.11.0)
(2024-09-20)


### Features

* **bld:** add NSLocalNetworkUsageDescription option for MacOS
([#1236](#1236))
([eea3f69](eea3f69)),
closes [#1235](#1235)


### Chores

* **bld:** remove repetitive code for updating MacOS Helper apps
([#1214](#1214))
([e1edc05](e1edc05))
* **cli:** migrate from yargs to commander
([#1216](#1216))
([7ca5a28](7ca5a28))
* **deps:** bump actions/setup-node from 4.0.3 to 4.0.4 in
/.github/workflows in the gha group
([#1232](#1232))
([8473fc6](8473fc6))
* **deps:** bump the npm group across 1 directory with 7 updates
([#1233](#1233))
([9efa2f4](9efa2f4))
* **deps:** bump vite from 5.3.5 to 5.4.6
([#1231](#1231))
([6135682](6135682))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants