-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copyFile method #148
Fix copyFile method #148
Conversation
We've been having some serious problems around this. See #142. When you say "Fix copyFile method", what exactly does this fix? Because I think there might be two / three problems overall. |
Acording #142, I had the same problem with .icns file. This is fixed in this fix. IMO, the problem is that when a file is not in destination after copy, another copying is executed. And another minor fix is that the method doesn't print something like chmod failed everytime it is executed (#147). It works for me. I am using my modification and I haven't encountered this (or any other) problem again. |
But yes this is just a workaround. This should be fixed in graceful-fs-extra.copy() method. It should not call the callback before the file is truly there. |
Ok cool, I'll test this today |
this fix work for me on osx 10.10 as also on my travis ci build... would really appriciate a merge to the official version of |
This fixed my issue on Windows. |
Can be this PR merged pls? |
Are there any problems with it? Adam, have you tested it? Do you need any explanation? Or what is taking you so long? |
Completely forgot to test it. I'm crazy busy. I'll try test this tonight I swear 😄. |
Awesome. |
Fix copyFile method somewhat
I still get the EMFILE myself but this does look like an improvement so I'm merging it in. |
emfile? ulimit -n 10000 does not work? |
@steida there's no |
It still seems like there is some type of threshold limit on windows. I can reproduce this "Error: EMFILE, open" issue reliably. |
When file doesn't exist after copy, DO NOT COPY IT AGAIN. We will only check its existence again.
fixes #147