fix: add back globing #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedoesdev
reviewed
Jan 5, 2023
| if (basename(content) === "package.json" && nwPkg === undefined) { | ||
| nwPkg = JSON.parse(await readFile(content)); | ||
| } | ||
| files.push(...contents); |
There was a problem hiding this comment.
Shouldn't this go outside the loop?
I'm getting
[ ERROR ] 2023-01-05T08:19:05.751Z Invalid array length
with it inside the loop when I have a large number of matched files.
There was a problem hiding this comment.
Additionally, this seems to conflict:
You describe srcDir as: "Directory to hold NW app files unless or array of file glob patterns"
But then you do this:
Line 89 in af32f10
If a user provides an array of glob patterns (like you document is allowed), it will fail.
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
nwbuildfunction parses the globing patterns insrcDir(for eg:srcDir: "./src/**/* .dist/**/*") and saves the list of file names in thefilesvariable. Thepackagerfunction uses the array to copy the relevant files to theoutDir.