Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct notify util #767

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Conversation

dominickbrasileiro
Copy link

Fixes: #766

Changes

  • import the packageJson directly instead of reading it in runtime.

@ayushmanchhabra
Copy link
Collaborator

Thanks for this! Once the lint error is fixed (disabled?), this is good to go.

@dominickbrasileiro
Copy link
Author

Unfortunately, the linter fails because import assertions were introduced in node v17.1.0 according to this. I had to work around it using the require and createRequire functions, so node >= 12 will be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify function resolving wrong package.json path
2 participants