Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create cacheDir and outDir before getting release info #772

Merged
merged 4 commits into from
Jan 15, 2023
Merged

fix: create cacheDir and outDir before getting release info #772

merged 4 commits into from
Jan 15, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Jan 15, 2023 •
edited
Loading

Fixes: #770
Closes: #771

  • Format
  • Lint
  • Test
  • Add name to AUTHORS (first time contributors)
  • Update CHANGELOG

Description

  • Create cacheDir, outDir before getting release info.
  • Use a flag to check if the nw release is cached.

@ayushmanchhabra ayushmanchhabra changed the title fix: create cacheDir and outDir before getting release info fix: create cacheDir and outDir before getting release info Jan 15, 2023
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review January 15, 2023 23:02
@ayushmanchhabra ayushmanchhabra merged commit 15b94c0 into main Jan 15, 2023
@ayushmanchhabra ayushmanchhabra deleted the dev-770 branch January 15, 2023 23:10
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manifest.json not being downloaded due to inexistent cache directory
1 participant
@ayushmanchhabra