Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes, bump to 1.1.0 #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfixes, bump to 1.1.0 #2

wants to merge 3 commits into from

Conversation

pajowu
Copy link
Contributor

@pajowu pajowu commented Sep 28, 2020

This PR fixes two bugs:

  1. Do not remove logfiles from the logfile map if their quota is updated. This lead to us removing all data from the sensor if the quota was changed at runtime.
  2. When appending a measurement, do not remove the logfile partition we just wrote to. This bug was triggered, when a storage quota < partition_size_bytes_default was set. The garbage collection marked the '0' partition to be deleted. After that the file was written, and then the marked partitions deleted, removing the just written data and leading to a corrupt storage.

@pajowu
Set quota in logfile instead of removing it from map
d0a0d10 
If we remove it from the map, all existing data is overwritten on the next insert operation.
@pajowu
Bugfix: Make sure currently used partition is not delted
611d264 
This bug was triggered, when a storage quota < partition_size_bytes_default was set.
The garbage collection marked the '0' partition to be deleted. After that the file
was written, and then the marked partitions deleted, removing the just written data
and leading to a corrupt storage.
@pajowu
Bump version
150db6f
@pajowu pajowu requested a review from asmuth September 28, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmuth asmuth Awaiting requested review from asmuth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pajowu