Jest Test Suite Set-up and some tests #109
Conversation
| ] | ||
| ], | ||
| "env": { | ||
| "test": { |
There was a problem hiding this comment.
hmm, it looks like there's no env stuff being set in the package.json. Is this being called correctly?
There was a problem hiding this comment.
Did some digging and there's no need to set a babel env in package.json because Jest will automatically set the env to test if it's not provided (per the doc here).
.circleci/config.yml
Outdated
| command: npm run lint | ||
| - run: | ||
| name: Run tests | ||
| command: npm run test |
There was a problem hiding this comment.
we should probably use parallelism: 4 and --maxWorkers=4 for jest to make use of it's parallel functionality. There's a good example in the kiln config.
Also, are we checking code coverage (via coveralls/etc) when we run tests?
There was a problem hiding this comment.
good idea, will add
| "overrides": [ | ||
| { | ||
| "files": ["src/**/*.js", "src/**/*.vue"], | ||
| "excludedFiles": "*.test.js" |
There was a problem hiding this comment.
why are tests excluded from eslint?
There was a problem hiding this comment.
I'm linting for TODO statements, but would like to leave them in tests as a breadcrumb for me or the next developer.
There was a problem hiding this comment.
Hmm, I'm worried that this might lead to issues down the line, but 👍 for now
There was a problem hiding this comment.
I'll try to remember to lint test files again when we have decent test coverage
src/services/add-service.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| import { getAvailableComponents, findParentUriAndList } from './utils'; | |||
| import { findSpaceLogic } from './create-service'; | |||
| import { setNewActive } from '../services/toggle-service'; | |||
| import { setNewActiveLogic } from '../services/toggle-service'; | |||
| import { last } from 'lodash'; | |||
There was a problem hiding this comment.
I don't think this will actually tree-shake lodash when all of clay-space-edit is compiled, will it?
There was a problem hiding this comment.
ahh I think you're right, webpack is not doing any tree-shaking. Will investigate
There was a problem hiding this comment.
K, added Lodash tree-shaking
src/services/create-service.js
Outdated
| @@ -99,7 +101,8 @@ function componentToSpace(store, ref, parentRef, spaceName) { | |||
| ] | |||
| }); | |||
| }) | |||
| .catch(function () { | |||
| .catch(function (res) { | |||
| console.log(res); | |||
src/services/toggle-service.js
Outdated
| if (activeUri) { | ||
| dom.find(`[data-uri="${activeUri}"]`).setAttribute(activeAttr, ''); | ||
| } | ||
| console.log('foo'); |
| dispatchCalls = []; | ||
| }); | ||
|
|
||
| // TODO: these tests are WIP |
There was a problem hiding this comment.
are these going to be a part of this PR, or a separate one?
There was a problem hiding this comment.
going to be a separate one
|
related to #20 |
This reverts commit c9b1f63.
|
We do cherry-picking in Kiln, but I think that requires doing |
|
lolo oops forgot to merge this in |
related #20
This PR includes:
add,create,remove,toggleserviceslodashThe kind of feedback I'm looking for:
Notes:
You'll notice that a lot of tests are asserting if a
dispatchobject is being defined correctly.clay-space-editis a plugin that hooks into Kiln's Vuex (the thing we're using do state management in Kiln) store and in order to trigger things that Kiln handles (like updating components),clay-space-editsends a dispatch to trigger actions. Instead of mocking all of Vuex, I'm just sending dispatches to an array, here