Skip to content

Commit

Permalink
Merge pull request #306 from nypublicradio/bono/DS-1003
Browse files Browse the repository at this point in the history
DS-1003: Header style updates to the home page
  • Loading branch information
bonomite authored Oct 18, 2021
2 parents 4d6649b + cc00574 commit 97f9d76
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 26,226 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Fortunately, `publisher` has its own set of easy-to-follow getting started instr
You will need the following software properly installed on your computer. Please follow all the directions as written on the websites of these projects and do not neglect to install their dependencies.

* [Git](http://git-scm.com/downloads)
* Node version 8 (install using [nvm](https://github.com/nvm-sh/nvm#installing-and-updating))
* Node version 10.0.0 (install using [nvm](https://github.com/nvm-sh/nvm#installing-and-updating))
* [Ember CLI](https://ember-cli.com/user-guide/#getting-started) (>= 2.6.0)
* [Grunt](http://gruntjs.com/getting-started)
* [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
Expand All @@ -33,7 +33,7 @@ We use [modernizr](https://modernizr.com/) to detect for certain browser feature
2. `$ git checkout <working branch>`
3. `$ cp .env.sample .env`
4. Edit `.env` with your `publisher` app location if you do _not_ want to use Publisher's demo environment, which is the default in `.env.sample`.
5. `$ yarn`
5. `$ yarn install`
6. `$ npm install [email protected]` :point-left: version can be unpinned if `wnyc-web-client` is migrated to Node >=v10
7. `$ npx grunt modernizr:dist`

Expand Down
44 changes: 34 additions & 10 deletions app/styles/legacy/_home-compat.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

#wnyc_home .story-wrapper {
h2 > a {
display: block;
border: none;
display: inline;
//border: none;

&:hover {
text-decoration: none;
Expand Down Expand Up @@ -260,7 +260,20 @@ body.ember-application {
}

#wnyc_home h2 {
font-weight: bold;
font-weight: 600;
letter-spacing: 0.1px;
font-size: 20px;
line-height: 1.25;
color: #333;
background-color: transparent;
& a{
text-decoration: none;
transition: border-color 250ms ease, color 250ms ease;
border-bottom: 1px solid rgba($blue, 0);
&:active, &:hover { outline: 0; }
&:focus, &:hover { border-bottom-color: $blue; }
&:hover { color: $blue; }
}
}

.story-wrapper {
Expand All @@ -286,14 +299,25 @@ body.ember-application {
}
}

@media screen and (min-width:800px) {
#home-primary {
h2 {
font-size: 20px;
}
#wnyc_home{
@media screen and (min-width:800px) {
#home-primary, #home-secondary, .shelf {
h2 {
font-size: 1.5rem;
line-height: 1.425;
}

.image {
border-radius: 3px 0 0 3px;
.image {
border-radius: 3px 0 0 3px;
}
}
#home-secondary h2{
font-size: 1.25rem;
line-height: 1.3;

}
.shelf h2{
font-size: 14px;
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion app/styles/legacy/_screen.scss
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,12 @@ h2.headline.norule {
text-transform: none;
}

h2 a, h3 a, h4 a {
h2 a {
color: #333;
text-decoration: none;
}

h3 a, h4 a {
color: #000;
text-decoration: none;
}
Expand Down
Loading

0 comments on commit 97f9d76

Please sign in to comment.