WE-6629: Update styles #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marineb
force-pushed
the
mboudeau/WE-6629-Update-styles
branch
2 times, most recently
from
6e67dc0
to
a58536b
Compare
noslouch
suggested changes
Dec 19, 2016
| @@ -20,6 +20,10 @@ | |||
| line-height: 32px; | |||
| margin-bottom: 0; | |||
| } | |||
|
|
|||
| > .h4 { | |||
There was a problem hiding this comment.
this seems kinda random. what's the use case?
There was a problem hiding this comment.
Yeah, good point. I'll update the markup in publisher instead (story template).
| line-height: 1.6em; | ||
| font-weight: bold; | ||
| } | ||
| } |
There was a problem hiding this comment.
let's put this in the legacy folder since the story page is due for a revamp to strictly ember
| @@ -48,6 +48,7 @@ body:not(.simplified_wrapper):not(.container_stripped) > :not( | |||
| @import 'slideshow'; | |||
| @import 'videoplayer'; | |||
| @import 'pagination'; | |||
| @import 'story'; | |||
There was a problem hiding this comment.
to @import 'legacy/story';
| @@ -522,7 +522,7 @@ var HTML = `<html> | |||
|
|
|||
|
|
|||
| <div class="media-body"> | |||
| <div class="text--small dimmed">Published in</div> | |||
| <div class="text--small dimmed">Published by</div> | |||
There was a problem hiding this comment.
this is an unused file, no need to update it.
marineb
force-pushed
the
mboudeau/WE-6629-Update-styles
branch
2 times, most recently
from
bde909f
to
8f0d179
Compare
marineb
force-pushed
the
mboudeau/WE-6629-Update-styles
branch
from
8f0d179
to
839c35b
Compare
marineb
force-pushed
the
mboudeau/WE-6629-Update-styles
branch
from
839c35b
to
5233737
Compare
noslouch
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.wnyc.org/browse/WE-6629
The last commit relates to #13 on Publisher.