Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bscharenberg/mt 126 #271

Merged
merged 6 commits into from
Mar 4, 2019
Merged

Bscharenberg/mt 126 #271

merged 6 commits into from
Mar 4, 2019

Conversation

bryn19
Copy link
Contributor

@bryn19 bryn19 commented Feb 26, 2019

No description provided.

happens, the daily-playlist page has the correct styling, as it will
directly linked to in the version update.
package.json Outdated
@@ -95,7 +95,7 @@
"normalize.css": "^8.0.0",
"nypr-account-settings": ">=0.2.2",
"nypr-ads": ">=0.1.0",
"nypr-audio-services": ">=0.5.1",
"nypr-audio-services": "nypublicradio/nypr-audio-services#a92c9701cff2fc6069e77186664c9f1e2800d892",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold on merging this to master until the new nypr-audio-services version is published, so you can just use the version number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Member

@kedmundson kedmundson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's get in the habit of always adding a description to the PR even if some of it is copy-pasted from the ticket. It's useful to have that right on the PR.

@bryn19 bryn19 merged commit 87344bf into master Mar 4, 2019
@bryn19 bryn19 deleted the bscharenberg/MT-126 branch March 4, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants