-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bscharenberg/mt 126 #271
Bscharenberg/mt 126 #271
Conversation
happens, the daily-playlist page has the correct styling, as it will directly linked to in the version update.
package.json
Outdated
@@ -95,7 +95,7 @@ | |||
"normalize.css": "^8.0.0", | |||
"nypr-account-settings": ">=0.2.2", | |||
"nypr-ads": ">=0.1.0", | |||
"nypr-audio-services": ">=0.5.1", | |||
"nypr-audio-services": "nypublicradio/nypr-audio-services#a92c9701cff2fc6069e77186664c9f1e2800d892", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold on merging this to master until the new nypr-audio-services
version is published, so you can just use the version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's get in the habit of always adding a description to the PR even if some of it is copy-pasted from the ticket. It's useful to have that right on the PR.
No description provided.