Add stylistic tweaks to the alt show page template #36
Conversation
marineb
changed the title
| background: linear-gradient(90deg, rgba(255, 255, 255, 0),rgba(255, 255, 255,1)); | ||
| position: absolute; | ||
| right: 0; | ||
| top: 5px; |
There was a problem hiding this comment.
Why isn't this height: 100% and top: 0?
There was a problem hiding this comment.
👌 I just made it taller instead.
| .flag { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; |
There was a problem hiding this comment.
Can you use the mixin instead of raw values? The mixin provides for crossbrowser compat
There was a problem hiding this comment.
Sorry, assumed our pre-processor was doing that. Changing!
| &:after { | ||
| content: " "; | ||
| width: 25px; | ||
| height: 40px; |
There was a problem hiding this comment.
I see you changed it, but specifically shouldn't this be 100% so that if the height of the list changes (maybe we use a bigger font size), this thing will adjust accordingly?
| .flag { | ||
| @include display-flex; | ||
| @include align-items(center); | ||
| @include justify-content(center); |
There was a problem hiding this comment.
use the flexbox mixin like so:
@include flexbox((
display: flex,
align-items: center,
justify-content: center
));There was a problem hiding this comment.
Sorry, I saw it used like I put it in other places. Will change!
No description provided.