Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send Streamed Show event when show changes #41

Merged
merged 8 commits into from
Jan 23, 2017
Merged

send Streamed Show event when show changes #41

merged 8 commits into from
Jan 23, 2017

Commits on Jan 20, 2017

  1. send Streamed Show event when show changes 

    only send it if it's changed from the previous fire and if it's playing
    Brian Whitton committed Jan 20, 2017
    Configuration menu
    Copy the full SHA
    08efae2 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2017

  1. dasherize current-story key in serializer so ember data can read it

    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    3c86a60 View commit details
    Browse the repository at this point in the history

  2. moves heardStream observer into its own method 

    it'll be called buy the audio-metadata's didReceiveAttrs hook
    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    094f4e8 View commit details
    Browse the repository at this point in the history

  3. call trackStreamData in didReceiveAttrs hook of audio-metadata component 

    better not to use an observer. @walsh9 I think this is a pattern we
can use to refactor the audio service analytics tangle
    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    2ba2d19 View commit details
    Browse the repository at this point in the history

  4. pass in showTitle attr to trigger didReceiveAttr hook

    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    347c1fe View commit details
    Browse the repository at this point in the history

  5. move story on stream event into trackStreamData

    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    cf80959 View commit details
    Browse the repository at this point in the history

  6. update tests for new audio metadata api

    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    aed289d View commit details
    Browse the repository at this point in the history

  7. don't need that computed prop

    Brian Whitton committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    2625c21 View commit details
    Browse the repository at this point in the history