Client-side DFP #45
Merged
Client-side DFP #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
February 1, 2017 16:59
will take over for component. initializer handles the setup * script tag * leaderboard mapping * slot definitions service calls refresh to display the ads and handles targeting for stories
don't need to use google-ad component anymore since the service will find and init
updated publisher too
noslouch
force-pushed
the
brian-WE-6398
branch
from
0683b27
to
cb9695b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the necessary bits so that the web client can manage DFP assets without any server-side initialization. This is another step in the process of moving client side concerns into the ember app.
The bits are an instance initializer which adds the async DFP script and also queues up all the one-time calls. Also this adds a service which routes can use to refresh ads once loaded.
Along the way, I also cleaned up some unnecessary code and moved the channel template out of a wormhole to coordinate with a simplified server template.
ticket