Legacy Cleanup #8
Conversation
noslouch
force-pushed
the
brian-legacy-cleanup
branch
from
b2c9d42
to
5feb35a
Compare
noslouch
force-pushed
the
brian-legacy-cleanup
branch
4 times, most recently
from
be67056
to
dcddf30
Compare
| @@ -2,5 +2,8 @@ export default function isJavascript(scriptTag) { | |||
| // TODO: add a console warning if the script tag doesn't have an attribute? | |||
| // seems like it's required for some parts of ember consumption | |||
| let type = scriptTag.attributes.type ? scriptTag.attributes.type.value : 'text/javascript'; | |||
| return /(?:application|text)\/(deferred-)?javascript/i.test(type); | |||
| // guard against chrome-extension:// scripts | |||
| let badSrc = scriptTag.src && !scriptTag.src.match(/^http|^\//); | |||
There was a problem hiding this comment.
Just checking on this, there's no worry of a relative import being used?
There was a problem hiding this comment.
not sure what you mean here
There was a problem hiding this comment.
I was just wondering if there would ever be a case where src would be relative to the HTML it's being used in, e.g. <script src="./bundle.js">, which would not match either ^http or ^/, but would still potentially be valid JS.
There was a problem hiding this comment.
ah, yeah. THAT IS A GOOD CATCH.
| {{link-to 'All Streams' 'stream' class="inherit" preventDefault=false}} | ||
| {{/link-to}} | ||
|
|
||
| {{#link-to 'schedule' current-when="schedule.date" tagName='li' href="false" class="list-item list-item--nav" }} | ||
| {{#link-to 'schedule' current-when="schedule.date" tagName='li' href=false class="list-item list-item--nav"}} |
There was a problem hiding this comment.
Minor quibble slash question for my own future coding: do we have a rule in our codebase for when to use singe vs. double quotes? It looks inconsistent in this file, for example current-when on this line vs. L124.
There was a problem hiding this comment.
there's no rule, but I prefer single quotes in all cases and escaping apostrophes in longer strings, but that's me.
noslouch
force-pushed
the
brian-legacy-cleanup
branch
from
6351f41
to
e98fd8c
Compare
landing on a nav link did not highlight navlink
script tags with a src attr that does not start with http or / are not JS
noslouch
force-pushed
the
brian-legacy-cleanup
branch
from
e98fd8c
to
db44212
Compare
Updates for better legacy compat. Depends on nypublicradio/publisher#6.