Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace strpos with strrpos since file names could be kebap case #28

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

DerFloe
Copy link

@DerFloe DerFloe commented Aug 13, 2024

Description

It seems to have been forgotten that vite uses base64 naming for the bundle prefix by default, which includes special characters such as - : https://rollupjs.org/configuration-options/#output-hashcharacters

This could lead to issues and should be addressed in the plugin's documentation, since otherwise the function does not extract the hash as intended.

In addition to that strpos might not be a proper function for determining the hash itself since the initial filename could be written in kebap case and strpos returns the first occurrence of a given character. Therefore my suggestion would be to take strrpos instead, as well as for determining the initial hashPos.

All in all it might even be better to give the developer the opportunity to define a custom hash prefix by for example an environment variable, since vite also allows custom naming of the output files using rollup. https://rollupjs.org/configuration-options/

Kind regards

Related issues

@DerFloe DerFloe requested a review from khalwat as a code owner August 13, 2024 11:21
@DerFloe DerFloe changed the title replace strpos with strrpos since file names could be kebap case fix: replace strpos with strrpos since file names could be kebap case Aug 13, 2024
@khalwat khalwat merged commit c61a32c into nystudio107:develop-v4 Aug 13, 2024
2 checks passed
@khalwat
Copy link
Contributor

khalwat commented Aug 13, 2024

Looks good, thanks

khalwat added a commit that referenced this pull request Aug 13, 2024
khalwat added a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants