Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nutritional information requests when in a block field type #64

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fixes nutritional information requests when in a block field type #64

merged 2 commits into from
Feb 21, 2023

Conversation

bencroker
Copy link
Collaborator

@bencroker bencroker commented Feb 21, 2023 •
edited
Loading

This PR fixes #63 requests to fetch nutritional information when the field is in a block field type (such as Matrix), by replacing the field name with its nameSpacedId.

@bencroker bencroker changed the title Fixes https://github.com/nystudio107/craft-recipe/issues/63 Fixes #63 Feb 21, 2023
@bencroker bencroker changed the title Fixes #63 Fixes nutritional information requests when in a block field type Feb 21, 2023
@khalwat
Copy link
Contributor

khalwat commented Feb 21, 2023

I'll port this from develop to develop-v4 too, so the change applies to both versions.

Thanks!

@khalwat khalwat merged commit 7654a60 into develop Feb 21, 2023
@bencroker bencroker mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalwat khalwat Awaiting requested review from khalwat khalwat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recipe field inside Matrix block.
2 participants
@bencroker @khalwat