Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry run logic for waiting on rollouts #137

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Add dry run logic for waiting on rollouts #137

merged 1 commit into from
Dec 3, 2020

Conversation

tonglil
Copy link
Member

@tonglil tonglil commented Dec 2, 2020

Don't wait for rollout when there is none due to the apply being a dry-run.

@tonglil tonglil requested a review from a team as a code owner December 2, 2020 18:53
Copy link

@swardlincoln swardlincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@tonglil tonglil merged commit f16c7f7 into master Dec 3, 2020
@tonglil tonglil deleted the dry-run-wait branch December 3, 2020 00:19
@montmanu
Copy link
Contributor

closes #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants