Drop node 12, add node 18 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tizmagik
commented
Oct 17, 2022
tizmagik
commented
- Node 12 is officially EOL since April 2022
- Add Node 18
| @@ -110,7 +110,7 @@ | |||
| "react": "^16.8.0 || ^17.0.0 || ^18.0.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.9.1", | |||
| "node": ">=18", | |||
There was a problem hiding this comment.
Hey @tizmagik, typically dropping support for older node versions is considered a breaking change, but this got pulled in on a minor version.
It also looks like this is dropping support for node 16 as well, which isn't in the release notes (it only mentions node 12)
as a result, we're seeing this on Node 16.19.1 now
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '[email protected]',
npm WARN EBADENGINE required: { node: '>=18', npm: '>=8.0.0' },
npm WARN EBADENGINE current: { node: 'v16.19.1', npm: '8.19.3' }
npm WARN EBADENGINE }
There was a problem hiding this comment.
Oh sorry about that. This should have been >=16.9. I can try and get a PR and re-release when I get some time, unless you have some bandwidth and would like to contribute 🙏
There was a problem hiding this comment.
I should have some time tomorrow to knock this out! thanks for the quick response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.